Skip to content

Adding touch-action utility #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Adding touch-action utility #4727

wants to merge 4 commits into from

Conversation

@MatteoGauthier
Copy link
Contributor

@MatteoGauthier MatteoGauthier commented Jun 20, 2021

Hey guys, i added the touch-action css property to tailwind :D

adamwathan
adamwathan requested changes Jun 21, 2021
View reviewed changes
Copy link
Member

@adamwathan adamwathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for this one, had this on my list to add soon so cool to have it come in as a PR! Left a few bits of feedback for things that need to change but generally looks good, thanks again.

@MatteoGauthier
Copy link
Contributor Author

MatteoGauthier commented Jun 21, 2021 •
edited
Loading

Thanks @adamwathan for your review, I tried to correct issues you noticed 📍

@MatteoGauthier
Copy link
Contributor Author

MatteoGauthier commented Jun 22, 2021

I don't know why the test fail..

@sachinraja
Copy link
Contributor

sachinraja commented Jun 22, 2021

I think the problem is that you didn't regenerate the fixtures after moving the import position. Looks like you'll also have to change the class's position in tests/jit/basic-usage.test.css. Tests pass for me after addressing both of these issues.

So you need to:

  1. npm run rebuild-fixtures
  2. move the touch-manipulation class to right after cursor-pointer in tests/jit/basic-usage.test.css.

@reinink reinink self-assigned this Sep 23, 2021
@adamwathan adamwathan mentioned this pull request Sep 26, 2021
Merged
@adamwathan
Copy link
Member

adamwathan commented Sep 26, 2021

Hey! We refactored the living hell out of the codebase since the time you opened this, so I just opened a new PR and included you as a co-author just to get this merged in quickly 👍🏻

#5603

Thanks a ton man!

@adamwathan adamwathan closed this Sep 26, 2021
@MatteoGauthier MatteoGauthier deleted the touch-action branch September 26, 2021 13:48
@MatteoGauthier
Copy link
Contributor Author

MatteoGauthier commented Sep 26, 2021

Hey! We refactored the living hell out of the codebase since the time you opened this, so I just opened a new PR and included you as a co-author just to get this merged in quickly 👍🏻

#5603

Thanks a ton man!

Thanks Adam ! Have a good day :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwathan adamwathan Awaiting requested review from adamwathan

Assignees

@reinink reinink

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MatteoGauthier @sachinraja @adamwathan @reinink